Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tedana.model to tedana.metrics #277

Closed
tsalo opened this issue Apr 30, 2019 · 3 comments · Fixed by #325
Closed

Rename tedana.model to tedana.metrics #277

tsalo opened this issue Apr 30, 2019 · 3 comments · Fixed by #325
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior

Comments

@tsalo
Copy link
Member

tsalo commented Apr 30, 2019

Summary

With #273 we'll be moving statistics-related functions out of tedana.model.fit, and so that module will become purely about metric calculation. This rename was proposed by @emdupre in her review of #266, but will be done separately to reduce PR bloat.

Next Steps

  1. Rename tedana/model/ to tedana/metrics/.
  2. Update all imports throughout package, including tests.
  3. Update API documentation.
@tsalo tsalo added the refactoring issues proposing/requesting changes to the code which do not impact behavior label Apr 30, 2019
@jbteves
Copy link
Collaborator

jbteves commented Jun 1, 2019

@tsalo have you started on this already? If not I'll try to take a crack at it.

@tsalo
Copy link
Member Author

tsalo commented Jun 1, 2019

I was planning to wait until after #266 was merged, and then never circled back to it after that happened. It would be awesome if you could do it.

@jbteves
Copy link
Collaborator

jbteves commented Jun 3, 2019

Cool, gave it a stab in #325 and requested your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring issues proposing/requesting changes to the code which do not impact behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants