Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Changes model module -> metrics module #325

Merged
merged 3 commits into from
Jun 6, 2019
Merged

[REF] Changes model module -> metrics module #325

merged 3 commits into from
Jun 6, 2019

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented Jun 3, 2019

Closes #277 .

Changes proposed in this pull request:

  • Renames tedana.model to tedana.metrics

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is 68.42%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #325   +/-   ##
======================================
  Coverage    49.2%   49.2%           
======================================
  Files          39      39           
  Lines        2140    2140           
======================================
  Hits         1053    1053           
  Misses       1087    1087
Impacted Files Coverage Δ
tedana/metrics/kundu_fit.py 29.47% <ø> (ø)
tedana/tests/test_model_kundu_metrics.py 100% <100%> (ø) ⬆️
tedana/metrics/__init__.py 100% <100%> (ø)
tedana/tests/test_model_fit_dependence_metrics.py 100% <100%> (ø) ⬆️
tedana/workflows/tedana.py 12.43% <20%> (ø) ⬆️
tedana/decomposition/pca.py 16.66% <50%> (ø) ⬆️
tedana/viz.py 9.86% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68892a8...4d13bc6. Read the comment docs.

@tsalo
Copy link
Member

tsalo commented Jun 3, 2019

@jbteves @emdupre what do you think about renaming fit.py to something more in line with our plans for expansion? I was thinking maybe meica.py, because these metrics are specific to the ME-ICA pipeline.

@jbteves
Copy link
Collaborator Author

jbteves commented Jun 3, 2019

@tsalo I think maybe kundu_fit since that's what we're naming what I would consider "original pipeline" code. We already have kundu_selection, for example. This seems like a natural extension. Plus I think it might be confusing to call something meica if we're deprecating it...

@emdupre
Copy link
Member

emdupre commented Jun 3, 2019

Agree that meica is likely to cause confusion, but I like the idea of renaming to make it clear that this was the original fitting method ! kundu_fit sounds just right to me 😸

@jbteves
Copy link
Collaborator Author

jbteves commented Jun 3, 2019

Okay, 4d13bc6 should fix that.

@jbteves jbteves merged commit 93a8e4e into ME-ICA:master Jun 6, 2019
@jbteves jbteves deleted the JT_rename_model2metrics branch June 6, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename tedana.model to tedana.metrics
3 participants