Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count of floored T2* values in logging #589

Closed
2 tasks
dowdlelt opened this issue Aug 3, 2020 · 2 comments · Fixed by #656
Closed
2 tasks

Add count of floored T2* values in logging #589

dowdlelt opened this issue Aug 3, 2020 · 2 comments · Fixed by #656
Labels
enhancement issues describing possible enhancements to the project priority: low issues that are not urgent

Comments

@dowdlelt
Copy link
Collaborator

dowdlelt commented Aug 3, 2020

Summary

Related to #585
We now have _apply_t2s_floor, which fixes divide by zero issues related to very low t2* estimates. It may be useful to have the option to record the number of voxels corrected with this, perhaps when asking for verbosity. I don't see any obvious dangers of the correction, but currently it is invisible.

Next Steps

  • count the number of voxels that have "bad" values
  • report this value if verbosity is requested.
@dowdlelt dowdlelt added enhancement issues describing possible enhancements to the project priority: low issues that are not urgent labels Aug 3, 2020
@jbteves
Copy link
Collaborator

jbteves commented Aug 3, 2020

Thanks for opening this issue @dowdlelt !
I agree that this would be good because if it happens a lot, it could be an early warning that something has gone wrong.

@stale
Copy link

stale bot commented Nov 1, 2020

This issue has been automatically marked as stale because it has not had any activity in 90 days. It will be closed in 600 days if no further activity occurs. Thank you for your contributions to tedana:tada: !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues describing possible enhancements to the project priority: low issues that are not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants