-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Add non-zero floor to T2* values #585
Conversation
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
+ Coverage 93.44% 93.53% +0.09%
==========================================
Files 26 26
Lines 1953 1965 +12
==========================================
+ Hits 1825 1838 +13
+ Misses 128 127 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this fix @tsalo !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, that error is always concerning to see. In the 'appearance is everything' sense, fixing this is a huge deal. I'm approving, but a thought about optionally (verbosely?) logging the number of voxels that needed to be fixed could be useful. Lets call that a future request.
@dowdlelt would you mind writing up an issue for that? |
Closes #513.
Todo:
Changes proposed in this pull request: