-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add verbose outputs for pipeline walkthrough #174
Conversation
# Conflicts: # tedana/workflows/tedana.py
# Conflicts: # tedana/workflows/tedana.py
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 51.98% 51.63% -0.35%
==========================================
Files 32 32
Lines 1941 1956 +15
==========================================
+ Hits 1009 1010 +1
- Misses 932 946 +14
Continue to review full report at Codecov.
|
# Conflicts: # tedana/decomposition/eigendecomp.py # tedana/workflows/tedana.py
It's passing! I think it's ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good ! I had a few questions. Hope NiMARE is going well !! 👻
Per discussion in #163 (see this comment), this PR adds in outputs necessary for #149.
I will need to update this PR after #152 is dealt with, but am keeping it separate to keep both PRs focused.
Changes proposed in this pull request:
label
,out_dir
, andverbose
arguments tofitmodels_direct
. Fitted models for TEDPCA and TEDICA can thus write out different files.fitmodels_direct
, including *_R2_pred.nii, *_S0_pred.nii, *_betas_catd.nii, and *_metric_weights.nii.R2_pred
is a 5D array (X x Y x Z x E x C) with the predicted value at each echo and voxel, for each component, for the R2 model.S0_pred
is the same, but for the S0 model.metric_weights
is a 4D array (X x Y x Z x C) with the voxel- and component-wise weights for averaging the R2 and S0 F values to get component-specific Kappa and Rho values.betas_catd
is a 5D (X x Y x Z x E x C) with the beta for the raw data at each echo for each component. These values are compared to the predicted values for the R2 and S0 models in evaluating model fit.verbose
argument totedpca
.