-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add tedana development setup instructions #197
Conversation
In the "Making a Change" section, instructions are given to run the setup.py script and notifies the user that any changes should be on their profile only, and should persist through most changes.
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 51.42% 51.42%
=======================================
Files 32 32
Lines 1964 1964
=======================================
Hits 1010 1010
Misses 954 954 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 51.42% 51.42%
=======================================
Files 32 32
Lines 1964 1964
=======================================
Hits 1010 1010
Misses 954 954 Continue to review full report at Codecov.
|
CONTRIBUTING.md
Outdated
``` | ||
python setup.py develop | ||
``` | ||
which should ensure all packages are correctly organized and linked on your user profile. Once you've run this, your repository should be set for most changes (i.e., you do not have to re-run with every change). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be nitpicky, but could you put each sentence on a new line ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, if you aren't nitpicky code style can get out of hand quickly, I understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great ! Thanks so much. I have one small requested change, but looking forward to seeing this merged !
I think this latest commit should address that, let me know if anything else needs to be changed. |
LGTM. Thx ! |
Closes #192 .
Changes proposed in this pull request: