Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add tedana development setup instructions #197

Merged
merged 2 commits into from
Jan 25, 2019
Merged

[DOC] Add tedana development setup instructions #197

merged 2 commits into from
Jan 25, 2019

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented Jan 24, 2019

Closes #192 .

Changes proposed in this pull request:

  • In "Making a Change," adds instructions to run setup.py for developers

In the "Making a Change" section, instructions are given to run the
setup.py script and notifies the user that any changes should be on
their profile only, and should persist through most changes.
@jbteves jbteves changed the title Add tedana development setup instructions [DOC] Add tedana development setup instructions Jan 24, 2019
@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   51.42%   51.42%           
=======================================
  Files          32       32           
  Lines        1964     1964           
=======================================
  Hits         1010     1010           
  Misses        954      954

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c821263...cdb20a6. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   51.42%   51.42%           
=======================================
  Files          32       32           
  Lines        1964     1964           
=======================================
  Hits         1010     1010           
  Misses        954      954

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c821263...9133d08. Read the comment docs.

CONTRIBUTING.md Outdated
```
python setup.py develop
```
which should ensure all packages are correctly organized and linked on your user profile. Once you've run this, your repository should be set for most changes (i.e., you do not have to re-run with every change).
Copy link
Member

@emdupre emdupre Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be nitpicky, but could you put each sentence on a new line ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, if you aren't nitpicky code style can get out of hand quickly, I understand.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great ! Thanks so much. I have one small requested change, but looking forward to seeing this merged !

@jbteves
Copy link
Collaborator Author

jbteves commented Jan 25, 2019

I think this latest commit should address that, let me know if anything else needs to be changed.

@emdupre
Copy link
Member

emdupre commented Jan 25, 2019

LGTM. Thx !

@emdupre emdupre merged commit 7d23934 into ME-ICA:master Jan 25, 2019
@jbteves jbteves deleted the JT_Add_Dev_Setup branch May 2, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer Tedana Config: import failure
2 participants