Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Clean up outdated/unused functions #227

Merged
merged 6 commits into from
Mar 1, 2019
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 27, 2019

Closes None. This PR will clean up the package a little bit. If we ever plan to re-integrate v3.2 into tedana, we can pull the removed functions from old releases.

Changes proposed in this pull request:

  • Remove the following functions tied to v3.2 of the selection criteria, which we no longer support:
    • selection._utils.do_svm
    • utils.moments
    • utils.gaussian
    • utils.fitgaussian
  • Remove the following functions which are outdated due to package-wide changes:
    • utils.get_dtype: We dropped support for surfaces, so I think this is no longer necessary. It's not used anywhere in the package.
    • io.ctabsel: We use csv/tsv files, and will use jsons, for the component tables. The old text files are no longer used.
  • Remove the minimum argument for utils.make_adaptive_mask. This argument set to True by default, but is actually never used.
  • Remove utils.make_min_mask. This goes with removing the minimum argument for utils.make_adaptive_mask.

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #227 into master will decrease coverage by 1.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   51.39%   50.34%   -1.05%     
==========================================
  Files          32       32              
  Lines        1975     1891      -84     
==========================================
- Hits         1015      952      -63     
+ Misses        960      939      -21
Impacted Files Coverage Δ
tedana/selection/_utils.py 14.28% <ø> (-0.61%) ⬇️
tedana/io.py 37.6% <ø> (+2.04%) ⬆️
tedana/workflows/tedana.py 14.18% <0%> (ø) ⬆️
tedana/utils.py 100% <100%> (+1.86%) ⬆️
tedana/workflows/t2smap.py 67.1% <100%> (ø) ⬆️
tedana/tests/test_decay.py 100% <100%> (ø) ⬆️
tedana/tests/test_utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c77da...7b7a8ff. Read the comment docs.

@ME-ICA ME-ICA deleted a comment from codecov bot Feb 27, 2019
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #227 into master will decrease coverage by 1.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   51.39%   50.34%   -1.05%     
==========================================
  Files          32       32              
  Lines        1975     1891      -84     
==========================================
- Hits         1015      952      -63     
+ Misses        960      939      -21
Impacted Files Coverage Δ
tedana/selection/_utils.py 14.28% <ø> (-0.61%) ⬇️
tedana/io.py 37.6% <ø> (+2.04%) ⬆️
tedana/workflows/tedana.py 14.18% <0%> (ø) ⬆️
tedana/utils.py 100% <100%> (+1.86%) ⬆️
tedana/workflows/t2smap.py 67.1% <100%> (ø) ⬆️
tedana/tests/test_decay.py 100% <100%> (ø) ⬆️
tedana/tests/test_utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c77da...a647ddc. Read the comment docs.

@emdupre
Copy link
Member

emdupre commented Mar 1, 2019

🎉 🎉 🎉

Love this. Merge when you're ready !

@tsalo tsalo merged commit 27bf65a into ME-ICA:master Mar 1, 2019
@tsalo tsalo deleted the clean-funcs branch March 17, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants