[FIX] Sort comptable by varex before identifying outlier components #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 45.94% 46.08% +0.14%
==========================================
Files 35 33 -2
Lines 2070 2046 -24
==========================================
- Hits 951 943 -8
+ Misses 1119 1103 -16
Continue to review full report at Codecov.
|
handwerkerd
previously approved these changes
May 3, 2019
|
Awesome! I'll wait until we merge #266, handle the merge conflicts, and then merge this in. |
# Conflicts: # tedana/selection/select_comps.py
|
Unfortunately the merge conflicts are being terrible, so I'm going to just close this and open a new PR from a fresh branch. |
|
Okay. I think that you should be able to fix them by rebasing this branch on top of master, resolving conflicts using "theirs" and then force-pushing here. But I'm not sure what exactly the conflicts are so I could be wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176. While this does not clarify everything about this step (e.g., why it is run three times specifically, or why the outlier components are excluded when computing elbows but not when selecting components later), it does resolve the most pressing issue of explaining why the step exists.
This was originally part of #247, but has been split off because it is self-contained and should be merged separately.
Changes proposed in this pull request:
ncls(components presumably without outlier variance explained) by descending variance explained. Before, the component table was sorted by descending Kappa values when identifying outliers. Per discussions with @handwerkerd, this was identified as a bug.