[ENH] Improve manual component selection #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow users to re-run tedana on the same directory without raising copyfile errors. - Retain original classification and rationale when manually overriding classification. - Allow manacc to be a list to make it easier to run within Python. - Clean up logic around checking mixm, ctab, and manacc arguments.
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=========================================
+ Coverage 46.11% 46.2% +0.09%
=========================================
Files 33 35 +2
Lines 2045 2058 +13
=========================================
+ Hits 943 951 +8
- Misses 1102 1107 +5
Continue to review full report at Codecov.
|
|
I have tested the various combinations of ctab, manacc, and mix locally, and everything seems to work fine. I think this is ready for review. |
emdupre
previously approved these changes
Apr 26, 2019
|
I think that's a good idea. I just made a commit with that change to the documentation, although the actual change to the manual classification will have to go in #266. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None. This was originally part of #247, but has been split off because it is self-contained and should be merged separately.
Changes proposed in this pull request:
manaccto be a list to make it easier to run within Python.