-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Split eigendecomp into ICA and PCA files #265
Conversation
- Move kundu_tedpca into selection module.
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 46.08% 46.75% +0.66%
==========================================
Files 33 35 +2
Lines 2044 2034 -10
==========================================
+ Hits 942 951 +9
+ Misses 1102 1083 -19
Continue to review full report at Codecov.
|
Sorry, why did we want to put ICA and PCA in their own modules ? |
The other changes are perhaps more important (e.g., moving kundu_tedpca into the selection module and removing the pcastate file), but my thinking is that separating ICA and PCA will work better when we add new decomposition methods (one of our future goals). Plus, if we want to support low-memory incremental PCA, then that may merit an additional function within pca.py (like run_mlepca). If we end up expanding the ICA- and PCA-related functions, then it makes sense to group them within their own submodules. |
# Conflicts: # tedana/decomposition/eigendecomp.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM ! Very small comments 👍
|
||
Returns | ||
------- | ||
mmix : (T x C) :obj:`numpy.ndarray` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the docstring include that this is z-scored ?
Co-Authored-By: tsalo <[email protected]>
Co-Authored-By: tsalo <[email protected]>
Co-Authored-By: tsalo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM ! ✨
Closes None. References #166. This was originally part of #247, but has been split off because it is self-contained and should be merged separately.
Changes proposed in this pull request: