Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev calls to contributing guidelines #271

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Add dev calls to contributing guidelines #271

merged 2 commits into from
Apr 23, 2019

Conversation

KirstieJane
Copy link
Member

@KirstieJane KirstieJane commented Apr 23, 2019

Addresses (but does not complete #270)

Changes proposed in this pull request:

  • Add dev calls & calendar to contributing guidelines

Happy to move this to a different part if that would be better? Let me know what you think's best 😸

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #271 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   46.11%   46.11%           
=======================================
  Files          33       33           
  Lines        2045     2045           
=======================================
  Hits          943      943           
  Misses       1102     1102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64ad6f...19bd294. Read the comment docs.

@jbteves
Copy link
Collaborator

jbteves commented Apr 23, 2019

@KirstieJane I'm slightly confused; how is this addressing #254 ? Or is this to loop the users on that thread in?


We run monthly developer calls via Zoom.
You can see the schedule via the `tedana` [google calendar](https://calendar.google.com/calendar/embed?src=pl6vb4t9fck3k6mdo2mok53iss%40group.calendar.google.com&ctz=Europe%2FLondon).
An agenda will be circulated in the gitter channel in advance of the meeting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I feel that if we say one will be circulated, we should say how far in advance. We should probably also decide a few more details on how the agenda will be managed, but that's out of the scope of this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeaaaaah.... I feel like that would be nice..... but difficult to commit to at the moment...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough; looks great!

@KirstieJane
Copy link
Member Author

Sorry for the wrong issue link! 🤦🏼‍♀️ Fixed now ✨

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me !

@KirstieJane
Copy link
Member Author

Ah - I'm not an authorised user 🙀

Ah well, please can someone merge? 👾

@emdupre
Copy link
Member

emdupre commented Apr 23, 2019

Whaaaa ? I'll look into this.

@emdupre emdupre merged commit e5cab53 into master Apr 23, 2019
@KirstieJane KirstieJane deleted the KJ-dev-calls branch April 23, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants