[TST] New smoke tests for functions in decay.py

[monicayao]

Addresses part of #335

Changes proposed in this pull request:

• Added smoke tests for fit_decay and fit_decay_ts
• Both tests are fashioned in the style of test_smoke_kundu_metrics from test_model_kundu_metrics.py
• Question for the new tests - should I check the size of the outputs, or is that outside the scope of a smoke test?

[jbteves]

Generally very good. Small technical point that I’d like corrected: the numbers generated are ints, not bools. In Python they can be casted to bool implicitly but the type of the matrix is still int.

[monicayao]

Generally very good. Small technical point that I’d like corrected: the numbers generated are ints, not bools. In Python they can be casted to bool implicitly but the type of the matrix is still int.

@jbteves ah yes! I was aware of this but since 0 and 1s have the same effect as false and trues I thought it would be fine to do this and add a comment to explain it.

Since it is called from the line data = data[mask] in decay.py, the effects are the same. Should I still change this?

[jbteves]

Oh, I just want the comment to not say bool, you don’t have to change the test. The most common descriptor is probably “binary mask.”

[codecov]

Codecov Report

Merging #367 into master will decrease coverage by 31.41%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #367       +/-   ##
===========================================
- Coverage   79.48%   48.06%   -31.42%     
===========================================
  Files          40       39        -1     
  Lines        2208     2251       +43     
===========================================
- Hits         1755     1082      -673     
- Misses        453     1169      +716

Impacted Files	Coverage Δ
tedana/tests/test_decay.py	100% <100%> (ø)	⬆️
tedana/viz.py	9.86% <0%> (-82.9%)	⬇️
tedana/selection/_utils.py	25% <0%> (-67.5%)	⬇️
tedana/decomposition/_utils.py	27.77% <0%> (-66.67%)	⬇️
tedana/metrics/kundu_fit.py	29.05% <0%> (-66.49%)	⬇️
tedana/decomposition/pca.py	14.77% <0%> (-65.91%)	⬇️
tedana/selection/tedica.py	23.52% <0%> (-64.71%)	⬇️
tedana/selection/tedpca.py	12.9% <0%> (-54.84%)	⬇️
tedana/workflows/tedana.py	9.46% <0%> (-53.91%)	⬇️
tedana/decomposition/ica.py	26.92% <0%> (-53.85%)	⬇️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26fece1...0e03783. Read the comment docs.

[jbteves]

LGTM, thanks!

[tsalo]

LGTM.

[tsalo]

@monicayao Is there anything else you wanted to do here or is this ready to merge?

[tsalo]

Can you pull from master to run the new testing setup?

[monicayao]

@tsalo Hi! I think this is ready to merge. I do want to make the random inputs a pytest fixture eventually, but I think that can come after writing the more important test functions first. I updated my branch from master, and everything ran as before. 🎉