Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix links and sizes in approach documentation #369

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 22, 2019

Closes None. I noticed that the Processing pipeline details page had some mistakes with the figures ever since I updated the notebook that generates them. This should fix that.

Changes proposed in this pull request:

  • Delete PCA figure that says "whiten" instead of "dimensionally reduce".
  • Re-generate figures with improved dimensions.
  • Adjust rendering dimensions in approach.rst.
  • Fix use of cumsum in MLE PCA for variance explained. Luckily this doesn't impact anything.

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #369 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   47.41%   47.41%           
=======================================
  Files          39       39           
  Lines        2223     2223           
=======================================
  Hits         1054     1054           
  Misses       1169     1169
Impacted Files Coverage Δ
tedana/decomposition/pca.py 14.77% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09767f7...760cf1f. Read the comment docs.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks !

@tsalo tsalo merged commit 0bdc8d4 into ME-ICA:master Jul 23, 2019
@tsalo tsalo deleted the fix-docs branch July 23, 2019 00:45
handwerkerd pushed a commit to handwerkerd/tedana that referenced this pull request Sep 11, 2019
* Remove buggy cumulative sum. Doesn't affect anything.

* Regenerate walkthrough figures. Fix links and sizes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants