Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Additional smoke tests for utils.py #377

Merged
merged 4 commits into from
Sep 6, 2019

Conversation

monicayao
Copy link
Contributor

Closes #335 .

Changes proposed in this pull request:

  • Added smoke tests to the functions in utils.py
  • Many functions, when they had only one output, were simply used in the assertion line (this may be edited, please give me your inputs!)

Bit of confusion with github, and had to start a fresh branch from the webs
@monicayao monicayao changed the title Pr335/utils [TST] Additional smoke tests for utils.py Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #377 into master will increase coverage by 0.74%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   79.74%   80.48%   +0.74%     
==========================================
  Files          40       40              
  Lines        2236     2255      +19     
==========================================
+ Hits         1783     1815      +32     
+ Misses        453      440      -13
Impacted Files Coverage Δ
tedana/tests/test_utils.py 100% <100%> (ø) ⬆️
tedana/tests/test_decay.py 100% <0%> (ø) ⬆️
tedana/utils.py 96.19% <0%> (+12.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ec6a2...ff537c7. Read the comment docs.

@emdupre emdupre mentioned this pull request Aug 14, 2019
3 tasks
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @monicayao !

@emdupre emdupre merged commit 87e5d58 into ME-ICA:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add smoke tests for files that handle the first few steps of tedana pipeline
2 participants