[FIX][TST] Adds curl installation where needed #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=========================================
Coverage ? 81.17%
=========================================
Files ? 41
Lines ? 2380
Branches ? 0
=========================================
Hits ? 1932
Misses ? 448
Partials ? 0Continue to review full report at Codecov.
|
jbteves
requested review from
tsalo and
emdupre
and removed request for
tsalo
|
@tsalo I don't know why it says I cancelled your review but I do in fact want it. |
jbteves
changed the title
jbteves
changed the title
jbteves
changed the title
tsalo
reviewed
Sep 10, 2019
| @@ -277,6 +281,7 @@ jobs: | |||
| - run: | |||
| name: Merge coverage files | |||
| command: | | |||
| apt-get install -y curl | |||
There was a problem hiding this comment.
Unbelievably, yes. Codecov uses curl to upload the report, that’s why it kept failing.
emdupre
approved these changes
Sep 10, 2019
tsalo
approved these changes
Sep 10, 2019
handwerkerd
added a commit
to handwerkerd/tedana
that referenced
this pull request
Sep 11, 2019
Adds curl installation where needed. NOTE: curl does not come pre-installed on the miniconda3 image that we use. NOTE: merge_coverage requires curl even though it is never explicitly called because codecov uses curl to upload the report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #388 .
Changes proposed in this pull request: