-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Replaces master with main where possible #667
Conversation
Codecov Report
@@ Coverage Diff @@
## master #667 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 26 26
Lines 2019 2019
=======================================
Hits 1893 1893
Misses 126 126 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @jbteves !
I'm getting three external links that don't (yet) resolve with main
, so I think we'll need to revert those changes for now. But overall, very happy to have this updated !!
Oh, silly me, good catches @emdupre ! |
Co-authored-by: Elizabeth DuPre <[email protected]>
Co-authored-by: Elizabeth DuPre <[email protected]>
Co-authored-by: Elizabeth DuPre <[email protected]>
I think the issue was that at some point GitHub had stated they would redirect |
No worries ! I was confused on that too -- the scikit link redirects correctly from |
So my plan to proceed, once we have approvals, is to do the following:
If there's no objections, then pending the additional review from @tsalo I'll go ahead. EDIT: Actually, I don't have permission to throw the switch, so either I need to be granted permission or someone else will need to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @jbteves . If we miss something we'll see after merging anyway. I'll be checking my notifications in case you need any help.
I've done the rename, but I'll also make sure you have permissions for the future. |
Addresses but does not close #619 .
Changes proposed in this pull request:
master
tomain
where applicableNOTE: due to versioneer and the document doc tree, there are some references to
master
that cannot be changed from my read. All examples below: