-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Support Windows' paths; Update zenodo & contributor count #672
Conversation
Codecov Report
@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 26 26
Lines 2030 2030
=======================================
Hits 1901 1901
Misses 129 129 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @notZaki !
It's weird that the patch has that one line both added and subtracted with no apparent change, but I'll go ahead and approve.
The reason for the split is that in "all contributors" we add non-code, non-authored contributions. The GitHub contributors will only list people who have committed or co-authored something added to the main branch. So, "all contributors" is the correct listing for the total number of contributors. I have no strong feelings about the Zenodo ordering. |
Thanks again, @notZaki ! 😄 re Windows : Thank you ! 🙏 We should probably add Azure testing.... re configuration : nice find ! I want to add "sort alphabetically," too. I'll see if I can get that changed. Don't worry about it in this PR. re mismatch : @jbteves 's explanation matches my understanding :) re: the zenodo : let's keep this as-is. The decision was that the software would always have the tedana community as first-author, but that individual outputs (like papers) could have different authorship orders / lists depending on who took on the writing, experiments, etc. re |
I'm going to approve and merge this now so it goes into the release (:tada: ) and we can open another issue to remove 🚀 🚀 🚀 |
Closes None.
Few small changes:
paths\like\this
instead of/like/that
.zenodo.json
The tedana Community
and bit of shufflinginfo/__credits__
which is out of sync and could be removed to simplify maintenanceThe full test suite passed on windows, mac, and ubuntu with Python 3.7-3.9 [log]