Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Improve gii file handling #74

Merged
merged 5 commits into from
Jun 4, 2018
Merged

Conversation

emdupre
Copy link
Member

@emdupre emdupre commented Jun 3, 2018

Changes proposed in this pull request:

  • Hot fix for gii file handling
  • Update for spatial artifacts in gii file

(cherry picked from commit 4576073)
@codecov
Copy link

codecov bot commented Jun 3, 2018

Codecov Report

Merging #74 into master will decrease coverage by <.01%.
The diff coverage is 5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   28.04%   28.03%   -0.01%     
==========================================
  Files          25       25              
  Lines        1373     1377       +4     
==========================================
+ Hits          385      386       +1     
- Misses        988      991       +3
Impacted Files Coverage Δ
tedana/utils/utils.py 78.26% <0%> (ø) ⬆️
tedana/selection/select_comps.py 0% <0%> (ø) ⬆️
tedana/info.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa4dfd...dfc86fc. Read the comment docs.

@emdupre emdupre changed the title [WIP, FIX] Initial patch for gii file handling [FIX] Improve gii file handling Jun 4, 2018
@emdupre
Copy link
Member Author

emdupre commented Jun 4, 2018

gifti files still need spatial information for proper functioning and are therefore currently unsupported in the existing pipeline. This patch improves individual file handling to easier integrate gifti spatial information in the future, as described in #34

@emdupre emdupre merged commit aed2ecc into ME-ICA:master Jun 4, 2018
@emdupre emdupre deleted the gii-patch branch June 4, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant