Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Disable report logging during ICA restart loop #743

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 7, 2021

Closes #738.

Changes proposed in this pull request:

  • Disable report logger (RepLGR) during ICA restart loop, then re-enable after the while loop is exited.

@tsalo
Copy link
Member Author

tsalo commented Jul 7, 2021

It works 🎉!

image

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #743 (06bfb65) into main (8aeadcc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   92.65%   92.66%           
=======================================
  Files          27       27           
  Lines        2137     2139    +2     
=======================================
+ Hits         1980     1982    +2     
  Misses        157      157           
Impacted Files Coverage Δ
tedana/workflows/tedana.py 90.36% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aeadcc...06bfb65. Read the comment docs.

@tsalo tsalo marked this pull request as ready for review July 7, 2021 17:44
@tsalo tsalo requested review from jbteves and eurunuela July 7, 2021 17:44
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @tsalo !

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tsalo !

@tsalo tsalo merged commit ee9669c into ME-ICA:main Jul 7, 2021
@tsalo tsalo deleted the fix-report-duplication branch July 7, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restarted decompositions add duplicate text to reports
3 participants