New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some Keccak testcases #67

Open

danielmarschall wants to merge 1 commit into MHumm:development from danielmarschall:patch-3

Contributor

danielmarschall commented May 5, 2024 •

edited

Loading

This PR contains 2 fixes:

It fixes a bug that was cause because an uninitialized variable LastByteLen instead of the argument LastByteLength was used.
I have reverted to AddLastByteForCodeTest(lDataRow, #$13, 5); again. I still have no clue why #$13 represents the test vector 0b10011, but for some reason it works. Maybe some day someone will find out why it works :-)

All test cases except the Unicode test case are working now. The Unicode test case might be impossible, though; see more details in #65


          Fixed Keccak testcases

2e8d2ec

All test cases except the Unicode test case are working now. MHumm#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet