Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ruby 2.7.5 #506

Merged
merged 1 commit into from
Mar 31, 2022
Merged

update to ruby 2.7.5 #506

merged 1 commit into from
Mar 31, 2022

Conversation

JPrevost
Copy link
Member

What does this PR do?

updates to ruby 2.7.5

Requires Database Migrations?

NO

Includes new or updated dependencies?

YES

@mitlib mitlib temporarily deployed to timdex-pipel-update-rub-ln1bfm March 23, 2022 17:32 Inactive
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to get the front page and the graphql playground running locally after installing 2.7.5, but I think I'm missing the right env / local elasticsearch to confirm everything fully works.

The tests pass, and the ping route works locally.
On the review app, I see the playground and the search route returning records.

Based on this, I think this is okay to merge - but if you'd like me to confirm local functionality I'll need to work with you to get the missing pieces in place.

@JPrevost
Copy link
Member Author

@matt-bernhardt as we'll be doing more dev work on this app soon we'll get you setup for local dev on it soonish. For now, I believe you confirmed the app worked as expected in the PR build and CI which were both running the updated Ruby so I think you can approve this PR based on that.

@JPrevost JPrevost merged commit 1fb6738 into main Mar 31, 2022
@JPrevost JPrevost deleted the update_ruby branch March 31, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants