Update to ruby 3.1.2 #554
Merged
Update to ruby 3.1.2 #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are these changes being introduced: * Updating to the latest ruby has many benefits, one of which is that it will allow us to upgrade the Heroku-18 stack to the latest Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-71 How does this address that need: * Updates ruby version in both files that store it Document any side effects to this change: * Adds `net-smtp` and realted gems to the Gemfile list. Once we upgrade to Rails 7.0.1 this should no longer be necessary. https://stackoverflow.com/a/70500221 For context, these gems were previously part of ruby, but were spun into separate gems as part of Ruby 3.1. Rails 7.0.1 resolved this by making those 3 gems dependencies (hence why we'll be able to remove them from explicitly being in our Gemfile when we upgrade).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
will allow us to upgrade the Heroku-18 stack to the latest
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
net-smtpto the Gemfile list. Once we upgrad to Rails 7 thisshould no longer be necessary. https://stackoverflow.com/a/70500221
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
YES