Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass environment to Sentry #563

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Pass environment to Sentry #563

merged 1 commit into from
Aug 11, 2022

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Aug 11, 2022

Why these changes are being introduced:

All Sentry alerts currently display the environment as 'production'.
We would like Sentry to accurately show the environment in which
the alert was captured.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ENGX-181

How this addresses that need:

This sets the Sentry environment to SENTRY_ENV, defaulting to
'unknown' if that variable isn't set.

Side effects of this change:

None.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

All Sentry alerts currently display the environment as 'production'.
We would like Sentry to accurately show the environment in which
the alert was captured.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ENGX-181

How this addresses that need:

This sets the Sentry environment to `SENTRY_ENV`, defaulting to
'unknown' if that variable isn't set.

Side effects of this change:

None.
@mitlib mitlib temporarily deployed to timdex-pr-563 August 11, 2022 12:47 Inactive
@jazairi
Copy link
Contributor Author

jazairi commented Aug 11, 2022

All Heroku apps have been updated with the corresponding environment.

@jazairi jazairi closed this Aug 11, 2022
@jazairi jazairi reopened this Aug 11, 2022
@JPrevost JPrevost self-assigned this Aug 11, 2022
@jazairi jazairi merged commit 42ae0aa into main Aug 11, 2022
@jazairi jazairi deleted the engx-181-add-sentry-env branch August 11, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants