Update Heroku stack and CI #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: We want to update our applications to use the Heroku 22 stack, which also requires us to use Ubuntu 22. Relevant ticket(s): https://mitlibraries.atlassian.net/browse/ENGX-180 https://mitlibraries.atlassian.net/browse/ENGX-182 How this addresses that need: This updates the CI config to point to the shared workflow and adds the Heroku stack version to app.json. Side effects of this change: * Updates webmock to the latest version, as the version currently installed has been removed from rubygems. * We cannot use the shared CI workflow with TIMDEX yet, since we need to run V1 and V2 tests separately. Once we retire V1, we should update this repo to use the shared workflow to make it consistent with our other Rails apps. I opened TIMX-84 to track this.
jazairi
force-pushed
the
engx-180-update-heroku-stack
branch
from
d53446a to
414894d
Compare
jazairi
changed the title
JPrevost
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We want to update our applications to use the Heroku 22
stack, which also requires us to use Ubuntu 22.
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/ENGX-180
https://mitlibraries.atlassian.net/browse/ENGX-182
How this addresses that need:
This updates the CI config to point to the shared workflow
and adds the Heroku stack version to app.json.
Side effects of this change:
To accommodate the shared CI workflow, the SimpleCov output
filename is now specified.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO