Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo in docs #594

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fixing typo in docs #594

merged 1 commit into from
Oct 6, 2022

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Oct 6, 2022

Thanks to a former colleague for pointing this out.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Thanks to a former colleague for pointing this out.
@mitlib mitlib temporarily deployed to timdex-pr-594 October 6, 2022 13:54 Inactive
@JPrevost JPrevost self-assigned this Oct 6, 2022
@matt-bernhardt matt-bernhardt merged commit c87a41d into main Oct 6, 2022
@matt-bernhardt matt-bernhardt deleted the matt-bernhardt-patch-1 branch October 6, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants