Fix tests #97
Merged
Fix tests #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/2zfzcn5kp |
kartikcho
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#90 broke tests on master. Problems:
exportin code imported from node_modules/@elg/speedscope. Changed our Babel and Jest configs to fix this following babel-jest does not transpile import/export in node_modules when Babel 7 is used jestjs/jest#6229 (comment)preprocessDatatests were not updated. This PR updates them, with some TODOs to be done in the remaining PRs in the stack based on [Optimize flamechart][1/4] Add flamechart to ReactProfilerData #90.Test Plan
yarn lint,yarn test)yarn flow: no change in errors