Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Simplification des statuts dans le code twig de la fiche signalement #3544

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

emilschn
Copy link
Collaborator

@emilschn emilschn commented Jan 10, 2025

Ticket

#3267

Description

Modification des noms de variables utilisées dans les twig de la fiche signalement, pour les rendre plus explicites, ou utiliser des Voter quand nécessaire.

Tests

  • Vérifier les boutons affichés dans différents signalements, dans différents statuts, avec le Super Admin
  • Idem avec un RT
  • Idem avec un agent

@emilschn emilschn requested review from numew and hmeneuvrier January 13, 2025 14:38
@emilschn emilschn changed the title [WIP] [Tech] Simplification des statuts dans le code twig de la fiche signalement [Tech] Simplification des statuts dans le code twig de la fiche signalement Jan 13, 2025
@emilschn emilschn requested a review from sfinx13 January 13, 2025 14:39
@emilschn emilschn marked this pull request as ready for review January 13, 2025 14:39
Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca me semble ok

@emilschn emilschn force-pushed the feature/3267-signalement-status-buttons branch from 7d7c2c4 to b864eff Compare January 21, 2025 13:02
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK !

@hmeneuvrier hmeneuvrier merged commit 6df57f0 into develop Jan 22, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants