Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): Introduce Banner component #1138

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat(components): Introduce Banner component #1138

merged 1 commit into from
Apr 17, 2024

Conversation

lwih
Copy link
Collaborator

@lwih lwih commented Apr 2, 2024 •
edited by ivangabriele
Loading

Description

Une banniere flotante qui a 3 thèmes de couleur et qui vient en version closable ou collapsible.

Version fermable:
https://github.com/MTES-MCT/monitor-ui/assets/4593884/ecf26327-8235-4443-b681-8b9be85b6413

Version collapse (pas forcément parfaite mais je veux montrer à Clémence)
https://github.com/MTES-MCT/monitor-ui/assets/4593884/0cf73ac3-fd87-4da2-8217-70c49add6c36

Tout feedback est le bienvenu, d'autant plus que je ne suis pas sûr de couvrir tous les besoins côté Monitor

Preview URL

https://637e01cf5934a2ae881ccc9d-iklwdtkzgg.chromatic.com/

@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (c8c39e0) to head (7a81fda).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
+ Coverage   56.96%   57.39%   +0.42%     
==========================================
  Files          54       55       +1     
  Lines         797      805       +8     
  Branches      272      274       +2     
==========================================
+ Hits          454      462       +8     
  Misses        327      327              
  Partials       16       16
Flag Coverage Δ
unit 57.39% <100.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwih lwih force-pushed the banner branch 2 times, most recently from bae393a to 05b1241 Compare April 2, 2024 14:50
@lwih lwih marked this pull request as ready for review April 2, 2024 15:36
@lwih lwih force-pushed the banner branch 2 times, most recently from 6f8d8e5 to 9f6fc6a Compare April 2, 2024 17:51
lwih
lwih commented Apr 2, 2024
View reviewed changes
src/components/Banner/__test__/Banner.test.tsx Outdated Show resolved Hide resolved
jest.setup.ts Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
lwih
lwih commented Apr 2, 2024
View reviewed changes
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
louptheron
louptheron reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour l'ajout !

Quelques petites remarques en commentaires, je laisse @claire2212 / @ivangabriele regarder également !

src/components/Banner/index.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Show resolved Hide resolved
src/components/Banner/__test__/Banner.test.tsx Outdated Show resolved Hide resolved
ivangabriele
ivangabriele reviewed Apr 4, 2024
View reviewed changes
stories/components/Banner.stories.tsx Show resolved Hide resolved
src/components/Banner/__test__/Banner.test.tsx Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
src/components/Banner/index.tsx Outdated Show resolved Hide resolved
@lwih lwih force-pushed the banner branch 2 times, most recently from 9131255 to ba73dd9 Compare April 9, 2024 12:34
ivangabriele
ivangabriele approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ivangabriele ivangabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un comment sinon sur les pre-commit hooks, tu peux faire un yarn dev:setup (qu'on pourrait au passage simplifier en virant le bash file) pour avoit le lint/type check au pre-commit. C'est un peu frustrant localement parce que ça ralentit le "committage" mais ça moins qu'une CI qui plante pour un simple problème de lint/typing IMO ;).

src/components/Banner/index.tsx Outdated Show resolved Hide resolved
@lwih lwih force-pushed the banner branch 2 times, most recently from 6d988ad to 99da220 Compare April 17, 2024 14:56
@lwih lwih merged commit 537b641 into main Apr 17, 2024
22 checks passed
@lwih lwih deleted the banner branch April 17, 2024 15:14
@ivangabriele
Copy link
Member

🎉 This PR is included in version 14.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claire2212 claire2212 claire2212 left review comments

@louptheron louptheron louptheron left review comments

@ivangabriele ivangabriele ivangabriele approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lwih @ivangabriele @louptheron @claire2212