Feature/Add proper stylesheet imports #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solution causes the same issues mentioned in #2 as rollup appears to skip bundling of the css file unless it's imported directly. Letting this stay open until a fix has been found. |
|
This is due to a bug in Vite detailed in vitejs/vite#2522, this PR stays open until it has been resolved. |
|
Vite now has support for the ?inline import flag, which includes the compiled css document as a string. This can be merged and closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Vite v3 you can now import postprocessed stylesheets as urls, this means we no longer need to use a hacky solution to import proper
<link>tags and include the global styles.