Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce envsubst for config.js, update deps #3032

Merged
merged 3 commits into from
Feb 12, 2023

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Feb 8, 2023

This is the implemenation of envsubst discussed in #1756

Documentation update will follow after merge.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #3032 (932de0d) into develop (4b478a5) will increase coverage by 0.32%.
The diff coverage is 83.63%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3032      +/-   ##
===========================================
+ Coverage    22.65%   22.97%   +0.32%     
===========================================
  Files           52       52              
  Lines        11455    11502      +47     
===========================================
+ Hits          2595     2643      +48     
+ Misses        8860     8859       -1     
Impacted Files Coverage Δ
js/app.js 82.36% <83.63%> (+0.09%) ⬆️
modules/default/updatenotification/node_helper.js 90.27% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example(maybe just with a comment in the sample.config so that people know how to use it?
Would it be possible to add a test for this?
And of course the async question if we convert the whole loadCOnfig mthod to async without callback?

js/app.js Outdated Show resolved Hide resolved
@khassel khassel requested a review from rejas February 12, 2023 18:13
.eslintignore Outdated Show resolved Hide resolved
@khassel khassel requested a review from rejas February 12, 2023 21:07
@rejas rejas merged commit a65ee86 into MagicMirrorOrg:develop Feb 12, 2023
@khassel khassel deleted the ensubst branch February 12, 2023 21:40
khassel added a commit to khassel/MagicMirror-Documentation that referenced this pull request Feb 12, 2023
khassel added a commit to khassel/MagicMirror-Documentation that referenced this pull request Feb 15, 2023
rejas pushed a commit to MagicMirrorOrg/MagicMirror-Documentation that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants