-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce envsubst for config.js, update deps #3032
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3032 +/- ##
===========================================
+ Coverage 22.65% 22.97% +0.32%
===========================================
Files 52 52
Lines 11455 11502 +47
===========================================
+ Hits 2595 2643 +48
+ Misses 8860 8859 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an example(maybe just with a comment in the sample.config so that people know how to use it?
Would it be possible to add a test for this?
And of course the async question if we convert the whole loadCOnfig mthod to async without callback?
This is the implemenation of envsubst discussed in #1756
Documentation update will follow after merge.