updatenotification: update_helper.js recode with pm2 library #3285
Conversation
…ete command-exists library (not used)
|
Like I have says this advantage:
inconvenient:
|
|
yeah, not sure about that axios vulnarbility from node-ical.... maybe we can add the v1.6.0 manually in our package.json and later remove it once node-ical update is working? would that work? |
|
we need node-ical 0.17.0 we aren't using the url ics approach node-ical provides.. |
|
it's not related to |
tested and not work because @pm2/js-api force another version in its own package.json |
|
It's really funny, because a lot of people are using pm2 cli with this problem and it doesn't bother them to install And naturally, on And here, we are looking for a solution |
|
The headache I have is that our "Review Dependencies" check will always error out once we merge this. And a check that always fails is worthless. |
| @@ -41,8 +41,7 @@ _This release is scheduled to be released on 2024-01-01._ | |||
| - Fix #3256 filter out bad results from rrule.between | |||
| - Fix calendar events sometimes not respecting deleted events (#3250) | |||
| - Fix electron loadurl locally on Windows when address "0.0.0.0" (#2550) | |||
| - Fix updatanotification (update_helper.js): catch error if reponse is not an JSON format (check PM2) | |||
| - Fix missing typeof in calendar module | |||
There was a problem hiding this comment.
The deletion of line 45 was not intentional, was it?
There was a problem hiding this comment.
maybe a oversight when i merged develop into it. will merge develop again now that other PRs got merged and re-add it
|
So I have 2 solutions:
or
|
|
That you can see my fix works now @rejas what I do ?
|
|
again another solution: recode
we can call It something like 'MM-pm2` (I'm able to do it) |
|
I would wait. there is no rush for this as a user I do not want auto update. |
|
humm... so best way is not code this functionality and close this PR ? |
|
no. wait til the needed support is there. |
| @@ -87,6 +86,7 @@ | |||
| "module-alias": "^2.2.3", | |||
| "moment": "^2.29.4", | |||
| "node-ical": "0.16.1", | |||
| "pm2": "https://github.com/bugsounet/pm2#build", | |||
There was a problem hiding this comment.
Why is the official package not used here?
There was a problem hiding this comment.
it's a draft... I test something but i plan to use official packet
I'm working about something else actually. I will see after ;)
Don't worry
|
recoded for v2.27.x with #3332 |
#3332) #3285 Because there is so many conflit with package, I have rewrite the code with v2.27.0-develop For remember: * recode: `update_helper.js` with `pm2` library * fix: default config -> `updates` is a array * delete: `command-exists` library (not used) * delete: `PM2_GetList()` function (not used) * add: check `updates.length` (prevent crash) * add: `[PM2]` tag in log (for better visibility) * add: `pm2` library advantage: * we use the pm2 library directly * avoids weird returns from child_process.exec when requesting a json format from pm2 * simplified the code inconvenient: * we have vulnerabilities with axios 240120 Fix: * use `pm2_env.pm_cwd` instead of `pm2_env.PWD` : prevent using `pm2 restart <id> --update-env` in other directory (for enable GPU rendering for exemple) * resolve packages (again)
Like i have say some few days ago.
update_helper.jswithpm2libraryupdatesis a arraycommand-existslibrary (not used)PM2_GetList()function (not used)updates.length(prevent crash)[PM2]tag in log (for better visibility)pm2library