-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update signature generator to new branding #10
Conversation
We need to use a non-gradient version of the logo because we don't want the gradient on a whitebackground (the yellow part of the gradient gets washed out). Side-note: I can't remember how this setup is affected by light mode / dark mode in email clients? |
I've updated the black logo image. This setup doesn't change anything for light and dark mode at the moment. I tested it in outlook and the received signature looks like this: |
I had a look into how we can make the signature switch and which logo it uses on light vs dark mode. We can use an SVG instead and add a media query styling as below within the svg. The problem with this is that it uses the user's system setting, not what the email client is set to (which may be different to the system setting). <style>
@media (prefers-color-scheme: dark) {
.cls-1 { fill: #fff; }
}
@media (prefers-color-scheme: light) {
.cls-1 { fill: #0e0f10; }
}
</style> Some other options that could work are to have a logo that is a colour that works well on both light/dark or add a background colour to the image or just leave it as is 🤷🏻♀️ |
src/constants/index.js
Outdated
brandLogo: { | ||
link: 'https://blog.makerx.com.au/content/images/2022/01/makerx_Full.png', | ||
link: 'https://makerxsignatures.blob.core.windows.net/images/MakerX-Full-Logo-Colored.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this URL isn't right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops I forgot to push a change for that, updating now for the one with the white background anyways
We should probably use the black logo for favicon, like the makerx website. Re: dark vs light mode, let's add a white background to the logo file then so at least it always looks right? |
Favicon is updated now too |
No description provided.