Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signature generator to new branding #10

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Conversation

melissahoughton
Copy link
Member

No description provided.

@robdmoore
Copy link
Member

We need to use a non-gradient version of the logo because we don't want the gradient on a whitebackground (the yellow part of the gradient gets washed out).

Side-note: I can't remember how this setup is affected by light mode / dark mode in email clients?

@melissahoughton
Copy link
Member Author

We need to use a non-gradient version of the logo because we don't want the gradient on a whitebackground (the yellow part of the gradient gets washed out).

Side-note: I can't remember how this setup is affected by light mode / dark mode in email clients?

I've updated the black logo image. This setup doesn't change anything for light and dark mode at the moment. I tested it in outlook and the received signature looks like this:

image

@melissahoughton
Copy link
Member Author

I had a look into how we can make the signature switch and which logo it uses on light vs dark mode. We can use an SVG instead and add a media query styling as below within the svg. The problem with this is that it uses the user's system setting, not what the email client is set to (which may be different to the system setting).

<style>
    @media (prefers-color-scheme: dark) {
      .cls-1 { fill: #fff; }
    }
    @media (prefers-color-scheme: light) {
      .cls-1 { fill: #0e0f10; }
    }
</style>

Some other options that could work are to have a logo that is a colour that works well on both light/dark or add a background colour to the image or just leave it as is 🤷🏻‍♀️

brandLogo: {
link: 'https://blog.makerx.com.au/content/images/2022/01/makerx_Full.png',
link: 'https://makerxsignatures.blob.core.windows.net/images/MakerX-Full-Logo-Colored.png',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this URL isn't right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I forgot to push a change for that, updating now for the one with the white background anyways

@robdmoore
Copy link
Member

We should probably use the black logo for favicon, like the makerx website.

Re: dark vs light mode, let's add a white background to the logo file then so at least it always looks right?

@melissahoughton
Copy link
Member Author

Updated to the use black logo jpg which has a white background already.

Screenshot from my personal outlook which uses dark mode:
image

@melissahoughton
Copy link
Member Author

Favicon is updated now too

@robdmoore robdmoore merged commit b787a45 into main Feb 4, 2025
1 check passed
@robdmoore robdmoore deleted the feature/new-brand branch February 4, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants