Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability for meshes with 3d texture #2274

Merged
merged 14 commits into from
Jan 15, 2025
Merged

add ability for meshes with 3d texture #2274

merged 14 commits into from
Jan 15, 2025

Conversation

SimonDanisch
Copy link
Member

So, that one can e.g. make a cut plane into a volume...

@MakieBot
Copy link
Collaborator

MakieBot commented Sep 14, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 5.40s (5.32, 5.47) 0.05+- 130.22ms (122.74, 144.95) 7.38+- 461.67ms (443.13, 485.53) 15.59+- 10.22ms (9.79, 10.85) 0.42+- 26.96ms (26.62, 27.10) 0.18+-
master 5.36s (5.24, 5.50) 0.08+- 130.70ms (121.21, 137.65) 5.82+- 454.43ms (439.29, 468.86) 11.15+- 10.10ms (9.33, 10.60) 0.41+- 26.84ms (26.59, 27.01) 0.16+-
evaluation 0.99x invariant, 0.05s (0.66d, 0.24p, 0.07std) 1.00x invariant, -0.48ms (-0.07d, 0.89p, 6.60std) 0.98x invariant, 7.24ms (0.53d, 0.34p, 13.37std) 0.99x invariant, 0.12ms (0.30d, 0.59p, 0.41std) 1.00x invariant, 0.11ms (0.66d, 0.24p, 0.17std)
CairoMakie 5.05s (4.94, 5.11) 0.06+- 115.00ms (112.87, 120.40) 2.54+- 174.43ms (171.10, 180.85) 3.20+- 9.70ms (9.47, 10.08) 0.22+- 1.22ms (1.16, 1.23) 0.03+-
master 4.99s (4.94, 5.05) 0.04+- 113.94ms (111.54, 116.72) 1.73+- 172.39ms (169.45, 174.69) 1.81+- 9.64ms (9.38, 9.97) 0.18+- 1.22ms (1.16, 1.24) 0.03+-
evaluation 0.99x invariant, 0.06s (1.17d, 0.05p, 0.05std) 0.99x invariant, 1.07ms (0.49d, 0.38p, 2.14std) 0.99x invariant, 2.05ms (0.79d, 0.17p, 2.50std) 0.99x invariant, 0.06ms (0.30d, 0.59p, 0.20std) 1.00x invariant, -0.0ms (-0.14d, 0.80p, 0.03std)
WGLMakie 5.73s (5.67, 5.79) 0.04+- 115.35ms (112.71, 117.64) 1.81+- 5.15s (5.09, 5.17) 0.03+- 12.27ms (12.11, 12.77) 0.22+- 117.24ms (112.40, 122.09) 3.55+-
master 5.76s (5.74, 5.80) 0.02+- 115.70ms (114.10, 117.97) 1.64+- 5.16s (5.07, 5.22) 0.05+- 12.38ms (12.18, 12.74) 0.18+- 117.10ms (112.67, 119.19) 2.19+-
evaluation 1.01x invariant, -0.03s (-1.02d, 0.09p, 0.03std) 1.00x invariant, -0.35ms (-0.20d, 0.71p, 1.72std) 1.00x invariant, -0.01s (-0.31d, 0.58p, 0.04std) 1.01x invariant, -0.11ms (-0.54d, 0.34p, 0.20std) 1.00x invariant, 0.14ms (0.05d, 0.93p, 2.87std)

@SimonDanisch SimonDanisch marked this pull request as ready for review October 4, 2024 13:04
@MakieBot
Copy link
Collaborator

MakieBot commented Jan 14, 2025

Benchmark Results

SHA: cede5c9f0035ba6aecc711eb785a16dc587c080e

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@SimonDanisch SimonDanisch merged commit 2a2f963 into master Jan 15, 2025
22 checks passed
@SimonDanisch SimonDanisch deleted the sd/3d-textures branch January 15, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants