Remove Settings.product.transformation

[himdel]

v2v product feature, this should be always on from 5.9.3 on - replaced by RBAC.

Goes together with ManageIQ/manageiq#17711 (and ManageIQ/manageiq-v2v#490).

Cc @Fryguy

[himdel]

@miq-bot add_label transformation, gaprindashvili/yes

[gmcculloug]

@miq-bot assign @Fryguy

[gmcculloug]

@himdel We do not back-port migrations so the gaprindashvili/yes label is not needed here. This would be applied to the next release, Hammer.

[himdel]

OK, removing the label, thanks :)

@miq-bot remove_label gaprindashvili/yes

[miq-bot]

@himdel unrecognized command 'remove', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

[miq-bot]

Checked commit https://github.com/himdel/manageiq-schema/commit/0f14276be08e50b76d3b4f2736de8f52411bde6e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[himdel]

@miq-bot add_label gaprindashvili/no
@miq-bot remove_label gaprindashvili/yes

[Fryguy]

@himdel I totally missed that this was a data migration that doesn't have any specs...can you add a spec in a separate PR please?

[himdel]

I ...am trying :).

Do we have any docs on running specs here?

$ be rspec spec/migrations/20180718132840_remove_transformation_product_setting_spec.rb
FF

Failures:

  1) RemoveTransformationProductSetting#up with empty tables
     Failure/Error: suppress_migration_messages { ActiveRecord::Migrator.migrate('db/migrate', version) }
     
     ActiveRecord::NoDatabaseError:
       FATAL:  database "dummy_test" does not exist
     # ./spec/support/migration_helper.rb:89:in `block in migrate_to'
     # ./spec/support/migration_helper.rb:83:in `suppress_migration_messages'
     # ./spec/support/migration_helper.rb:89:in `migrate_to'
     # ./spec/support/migration_helper.rb:25:in `prepare_migrate'
     # ./spec/support/migration_helper.rb:8:in `block (2 levels) in migration_context'
     # ------------------
     # --- Caused by: ---
     # PG::ConnectionBad:
     #   FATAL:  database "dummy_test" does not exist
     #   ./spec/support/migration_helper.rb:89:in `block in migrate_to'

  2) RemoveTransformationProductSetting#up removes the /product/transformation key
     Failure/Error: suppress_migration_messages { ActiveRecord::Migrator.migrate('db/migrate', version) }
     
     ActiveRecord::NoDatabaseError:
       FATAL:  database "dummy_test" does not exist
     # ./spec/support/migration_helper.rb:89:in `block in migrate_to'
     # ./spec/support/migration_helper.rb:83:in `suppress_migration_messages'
     # ./spec/support/migration_helper.rb:89:in `migrate_to'
     # ./spec/support/migration_helper.rb:25:in `prepare_migrate'
     # ./spec/support/migration_helper.rb:8:in `block (2 levels) in migration_context'
     # ------------------
     # --- Caused by: ---
     # PG::ConnectionBad:
     #   FATAL:  database "dummy_test" does not exist
     #   ./spec/support/migration_helper.rb:89:in `block in migrate_to'

Finished in 0.01529 seconds (files took 0.85142 seconds to load)
2 examples, 2 failures

[himdel]

diff --git a/spec/migrations/20180718132840_remove_transformation_product_setting_spec.rb b/spec/migrations/20180718132840_remove_transformation_product_setting_spec.rb
new file mode 100644
index 0000000..72e00ac
--- /dev/null
+++ b/spec/migrations/20180718132840_remove_transformation_product_setting_spec.rb
@@ -0,0 +1,17 @@
+require_migration
+
+describe RemoveTransformationProductSetting do
+  let(:settings_change_stub) { migration_stub(:SettingsChange) }
+
+  migration_context :up do
+    it "removes the /product/transformation key" do
+      setting_changed = settings_change_stub.create!(:key => "/product/transformation", :value => true)
+      setting_ignored = settings_change_stub.create!(:key => "/product/magic", :value => true)
+
+      migrate
+
+      expect(setting_changed.reload.value).to eq(nil) # TODO?
+      expect(setting_ignored.reload.value).to eq(true)
+    end
+  end
+end

This is probably close, I'll create a PR once I can test it

[carbonin]

@himdel bundle exec rake spec:setup should do the trick

Just make sure you set up the spec/dummy/config/database.yml so that it can connect to your local db.

[himdel]

Aah, silly me, thanks! :) Good to know about spec/dummy/config/database.yml (but turns out it works out of the box)

[himdel]

Should be ready in #249 :)