-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table for service instances #267
Conversation
Add table for service instances. We need the service instances modeled to be able to do service retirement.
@gmcculloug @gtanzillo @agrare so we've talked with @syncrou and without this modeled, we are not able to retire the services. |
Checked commit Ladas@0d9d17d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20180827083140_create_service_instances_table.rb
|
@Ladas Totally understand, the current effort we are working on is purely focused on ordering. While we do not have an immediate need for this data I suspect we (or someone) will in the future. Likely, the near future. |
so, do we have better naming than service_instance? |
@gmcculloug are you good with the name "service_instances"? |
@syncrou what do you think of the name? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the referencing foreign key ( service_offering_id ) is the one piece that saves us from getting very confused with service_templates, service which have nothing to do with service_offerings, service_instances. LGTM 👍
@bdunne can you add the API also for |
Add table for service instances. We need the service instances
modeled to be able to do service retirement.