Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table for service instances #267

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Aug 29, 2018

Add table for service instances. We need the service instances
modeled to be able to do service retirement.

Add table for service instances. We need the service instances
modeled to be able to do service retirement.
@Ladas
Copy link
Contributor Author

Ladas commented Aug 29, 2018

@miq-bot assign @agrare
@miq-bot add_label enhancement

@Ladas
Copy link
Contributor Author

Ladas commented Aug 29, 2018

@gmcculloug @gtanzillo @agrare so we've talked with @syncrou and without this modeled, we are not able to retire the services.

@miq-bot
Copy link
Member

miq-bot commented Aug 29, 2018

Checked commit Ladas@0d9d17d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

db/migrate/20180827083140_create_service_instances_table.rb

@gmcculloug
Copy link
Member

@Ladas Totally understand, the current effort we are working on is purely focused on ordering. While we do not have an immediate need for this data I suspect we (or someone) will in the future. Likely, the near future.

@Ladas
Copy link
Contributor Author

Ladas commented Aug 29, 2018

so, do we have better naming than service_instance?

@agrare
Copy link
Member

agrare commented Sep 6, 2018

@gmcculloug are you good with the name "service_instances"?

@agrare
Copy link
Member

agrare commented Sep 11, 2018

@syncrou what do you think of the name?

Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the referencing foreign key ( service_offering_id ) is the one piece that saves us from getting very confused with service_templates, service which have nothing to do with service_offerings, service_instances. LGTM 👍

@agrare agrare merged commit 1688fbd into ManageIQ:master Sep 11, 2018
@agrare agrare modified the milestones: Sprint 94 Ending Sept 24, 2018, Sprint 95 Ending Sep 24, 2018 Sep 11, 2018
@Ladas
Copy link
Contributor Author

Ladas commented Sep 12, 2018

@bdunne can you add the API also for service_instances ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants