Default VM connection_state is now 'connected' #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to ManageIQ/manageiq#18216 @miq-bot add_label data |
agrare
requested changes
Nov 19, 2018
miha-plesko
force-pushed
the
default-vm-connection-state
branch
from
cef22dd to
3032ff3
Compare
|
Nice find @agrare , didn't think of VmOrTemplate, updated. |
agrare
approved these changes
Nov 19, 2018
agrare
reviewed
Nov 19, 2018
| end | ||
| end | ||
|
|
||
| describe 'in other region' do |
There was a problem hiding this comment.
@miha-plesko we don't need to test that in_my_region works so you can just get rid of this and simplify the tests a bit
With this commit we migrate all occurances of ``` vm.connection_state == nil ``` to now contain 'connected' instead nil. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
default-vm-connection-state
branch
from
3032ff3 to
c8b9cb8
Compare
|
Simplified the specs, good to go @agrare |
|
Checked commit miha-plesko@c8b9cb8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20181119154009_set_vm_connection_state.rb
|
|
Thanks @miha-plesko |
|
Also, thanks for using Good stuff |
👍 agreed
😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we migrate all occurances of
to now contain 'connected' instead nil.
@miq-bot assign @agrare
/cc @kbrock