Add name validation to service templates #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
previously requested changes
Mar 8, 2019
db/migrate/20190228210310_service_templates_should_have_names.rb
Outdated
Show resolved
Hide resolved
db/migrate/20190228210310_service_templates_should_have_names.rb
Outdated
Show resolved
Hide resolved
db/migrate/20190228210310_service_templates_should_have_names.rb
Outdated
Show resolved
Hide resolved
spec/migrations/20190228210310_service_templates_should_have_names_spec.rb
Show resolved
Hide resolved
d-m-u
force-pushed
the
service_templates_should_have_names
branch
from
0fd27c6 to
8920faf
Compare
bdunne
reviewed
Mar 8, 2019
db/migrate/20190228210310_service_templates_should_have_names.rb
Outdated
Show resolved
Hide resolved
d-m-u
force-pushed
the
service_templates_should_have_names
branch
from
8920faf to
5ceca16
Compare
|
Checked commit d-m-u@5ceca16 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@jrafanie can I please get eyes on this? |
carbonin
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a method to copy service_templates 21 days ago here ManageIQ/manageiq@955f49b#diff-9257fff45a7d1258305c9a6b7d15e322R48 and in the process discovered that it's valid for templates to not have names and I think templates should have names.