Add Resource to OpenSCAP results #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Jul 17, 2017
| class AddSubjectToOpenScapResult < ActiveRecord::Migration[5.0] | ||
| def change | ||
| add_column :openscap_results, :subject_id, :bigint | ||
| add_column :openscap_results, :subject_type, :string |
There was a problem hiding this comment.
If this is a polymorphic reference, prefer :resource_id, :resource_type for consistency with other models (We use resource as opposed to subject in the models...also subject is kind of a keyword in RSpec which could be confusing)
There was a problem hiding this comment.
@Fryguy Thanks for comment and info behind, updated.
Adding resource_id and resource_type fields to openscap_results table to allow assigning OpenSCAPResult to OpenStack VMs and later also other inventory. Existing container_id association is not touched in this PR, but it could be migrated to polymorphic the resource association in future.
aufi
force-pushed
the
add_subject_to_openscap_results
branch
from
b2fd722 to
277fbcc
Compare
aufi
changed the title
|
Checked commit aufi@277fbcc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding resource_id and resource_type fields to openscap_results table
to allow assigning OpenSCAPResult to OpenStack VMs and later also
other inventory.
Existing container_id association is not touched in this PR, but it could
be migrated to the polymorphic resource association in future.