Disable CRUD for Network provider elements for non-OpenStack providers

[AparnaKarve]

Disable CRUD for Network provider elements (like Network Routers, Floating IPs, Security Groups) for non-Openstack providers.

https://bugzilla.redhat.com/show_bug.cgi?id=1440684

Configuration Menu for Networks -> Security Groups when at least one OpenStack Network Manager exists
Add a New Security Group is enabled

Configuration Menu for Networks -> Security Groups when OpenStack Network Managers do not exist
Add a New Security Group is disabled

Screenshots for Add a New Network Router and Add a new Floating IP would be similar in the presense/absence of an OpenStack Network Manager

[AparnaKarve]

@Ladas Please review.

I also need a confirmation on the following --

2.3.1 :009 > EmsNetwork.first
  ManageIQ::Providers::NetworkManager Load (2.4ms)  SELECT  "ext_management_systems".* FROM "ext_management_systems" WHERE "ext_management_systems"."type" IN ('ManageIQ::Providers::NetworkManager', 'ManageIQ::Providers::Google::NetworkManager', 'ManageIQ::Providers::Nuage::NetworkManager', 'ManageIQ::Providers::Openstack::NetworkManager', 'ManageIQ::Providers::Amazon::NetworkManager', 'ManageIQ::Providers::Azure::NetworkManager', 'ManageIQ::Providers::Vmware::NetworkManager') ORDER BY "ext_management_systems"."id" ASC LIMIT $1  [["LIMIT", 1]]
  ManageIQ::Providers::NetworkManager Inst Including Associations (0.2ms - 1rows)
 => #<ManageIQ::Providers::Openstack::NetworkManager id: 1000000000025, name: "OSP7 Packstack (10.39.167.117) Network Manager", created_on: "2017-04-11 19:24:28", updated_on: "2017-04-11 19:24:28", guid: "7b279290-1eec-11e7-a56e-b8e856429d10", zone_id: nil, type: "ManageIQ::Providers::Openstack::NetworkManager", api_version: nil, uid_ems: nil, host_default_vnc_port_start: nil, host_default_vnc_port_end: nil, provider_region: nil, last_refresh_error: nil, last_refresh_date: nil, provider_id: nil, realm: nil, tenant_id: nil, project: nil, parent_ems_id: 1000000000007, subscription: nil, last_metrics_error: nil, last_metrics_update_date: nil, last_metrics_success_date: nil, tenant_mapping_enabled: nil> 

Note that the EmsNetwork.first record is OpenStack.

2.3.1 :010 > NetworkRouter.class_by_ems(EmsNetwork.first).supports_create?
  ManageIQ::Providers::NetworkManager Load (1.5ms)  SELECT  "ext_management_systems".* FROM "ext_management_systems" WHERE "ext_management_systems"."type" IN ('ManageIQ::Providers::NetworkManager', 'ManageIQ::Providers::Google::NetworkManager', 'ManageIQ::Providers::Nuage::NetworkManager', 'ManageIQ::Providers::Openstack::NetworkManager', 'ManageIQ::Providers::Amazon::NetworkManager', 'ManageIQ::Providers::Azure::NetworkManager', 'ManageIQ::Providers::Vmware::NetworkManager') ORDER BY "ext_management_systems"."id" ASC LIMIT $1  [["LIMIT", 1]]
  ManageIQ::Providers::NetworkManager Inst Including Associations (0.2ms - 1rows)
 => false 

Does that seem right that supports_create? returns a false for NetworkRouter for OpenStack?

It returns a true for SecurityGroup and FloatingIP

[Ladas]

@tzumainn could you verify which actions are supported on OpenStack?

[tzumainn]

@Ladas This looks right to me - we support :create for all three of these.

[AparnaKarve]

This looks right to me - we support :create for all three of these.

@tzumainn In that case, NetworkRouter does not seem to be working correctly like I have demonstrated above. It's returning false for supports_create?
Can you verify that? Thanks.

[tzumainn]

@AparnaKarve Ah, sorry - it looks like the network router code hasn't been updated yet; it supports :create_network_router instead

[miq-bot]

Checked commits AparnaKarve/manageiq-ui-classic@a4dc1fa~...d0f2689 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
9 files checked, 0 offenses detected
Everything looks good. 🍰

[AparnaKarve]

Thanks @tzumainn.
I'm now using supports_create_network_router? to enable/disable the Add action for Network Routers.

[simaishi]

Fine backport details:

$ git log -1
commit b7e435bf8f6552f51369936b92b706d839047aae
Author: Milan Zázrivec <[email protected]>
Date:   Thu Apr 13 10:34:15 2017 +0200

    Merge pull request #1007 from AparnaKarve/bz1440684_disable_network_crud_for_non_openstack
    
    Disable CRUD for Network provider elements for non-OpenStack providers
    (cherry picked from commit 7cf860a3d44c8fdd2d38d436b9e0310c170391c4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1442150

[AparnaKarve]

@miq-bot remove_label euwe/conflict

[AparnaKarve]

EUWE PR: ManageIQ/manageiq#15077

[simaishi]

Backported to Euwe via ManageIQ/manageiq#15077