Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix topology project icon #1013

Merged
merged 1 commit into from
Apr 12, 2017
Merged

fix topology project icon #1013

merged 1 commit into from
Apr 12, 2017

Conversation

zeari
Copy link

@zeari zeari commented Apr 12, 2017 •
edited
Loading

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1439585
Pretty simple change. though I cant figure out why the value changed.

Before:
screencapture-localhost-3000-container_project-show-1-1491988584252 1

After:
screencapture-localhost-3000-container_project-show-1-1491988479935

@himdel @martinpovolny Please review

@zeari
Copy link
Author

zeari commented Apr 12, 2017

cc @simon3z

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

Checked commit zeari@ad39129 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

simon3z
simon3z approved these changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@simon3z simon3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@miq-bot assign dclarizio
cc @epwinchell @serenamarie125 @h-kataria

@simon3z
Copy link
Contributor

simon3z commented Apr 12, 2017

@miq-bot add_label providers/containers

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

@simon3z Cannot apply the following label because they are not recognized: providers/containers

@simon3z
Copy link
Contributor

simon3z commented Apr 12, 2017

@miq-bot add_label compute/containers

@simon3z
Copy link
Contributor

simon3z commented Apr 12, 2017

@miq-bot assign dclarizio

@himdel
Copy link
Contributor

himdel commented Apr 12, 2017

LGTM, pficon-project is e906, not e622 👍

The only thing.. I'm not seeing it in the top bar with all the other entities, isn't that a bug too?

@zeari
Copy link
Author

zeari commented Apr 12, 2017

The only thing.. I'm not seeing it in the top bar with all the other entities, isn't that a bug too?

@himdel its the center of the graph which we dont really allow to toggle. Its the topology for the project...

@himdel himdel added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 12, 2017
@himdel
Copy link
Contributor

himdel commented Apr 12, 2017

Aah, thanks! Makes sense .. well, in that case ... merged :D

@himdel himdel merged commit 079f752 into ManageIQ:master Apr 12, 2017
@himdel himdel assigned himdel and unassigned dclarizio Apr 12, 2017
@Loicavenel
Copy link

@zeari thanks

simaishi pushed a commit that referenced this pull request Apr 13, 2017
@himdel @simaishi
Merge pull request #1013 from zeari/fix_topology_project_icon
9fb00c2 
fix topology project icon
(cherry picked from commit 079f752)

https://bugzilla.redhat.com/show_bug.cgi?id=1441661
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 9fb00c29abd39968f8f8d8f473dd3c07bcb0cc89
Author: Martin Hradil <[email protected]>
Date:   Wed Apr 12 11:24:24 2017 +0000

    Merge pull request #1013 from zeari/fix_topology_project_icon
    
    fix topology project icon
    (cherry picked from commit 079f752023276bca0736029954cf5103325119d0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1441661

@abonas
Copy link
Member

abonas commented May 14, 2017

@miq-bot add_label topology

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon3z simon3z simon3z approved these changes

Assignees

@himdel himdel

Labels
bug compute/containers fine/backported graphics topology
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zeari @miq-bot @simon3z @himdel @Loicavenel @simaishi @abonas @dclarizio