Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a ems_id existence check around VM VNC console button visibility #1723

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Jul 19, 2017

calling 'api_version' for VM with ems_id as nil was throwing an error when accessing Archived/Orphaned vmware VM summary screen(Need to set Console type support is set to 'VNC')

https://bugzilla.redhat.com/show_bug.cgi?id=1472973

@dclarizio please review/test

VMware VM with VNC console button
vmware_vm

Orphaned VMware VM with no VNC console button
orphaned_vm

@dclarizio
Copy link

dclarizio commented Jul 19, 2017

@Loicavenel seeing as both archived and orphaned VMs have no EMS and hence can't open a console, do you think we should totally hide this button or present it disabled with a tooltip saying consoles won't work against them?

@Loicavenel
Copy link

@dclarizio
So, if the option is never available, we should hide it.. If this is depending of a state we grey out..
So, here hide it.

Question: For Orphan VMs, why EMS is required to open a console, IP is not enough?

@h-kataria
Copy link
Contributor Author

@Loicavenel we need to find out the api version of a connected EMS to figure out if that's a supported version, which in case does not exist.

@h-kataria
Copy link
Contributor Author

Discussed with @agrare and found out that it is not possible to open a VNC console for Archived or Orphaned VMs, so i am going to make changes to this PR to Hide the VNC Console button for such VMs.

@h-kataria h-kataria force-pushed the fixed_visibility_code_for_vnc_console_button branch from 0c7796e to daf5112 Compare July 21, 2017 17:03
calling 'api_version' for VM with ems_id as nil was throwing an error when accessing Archived/Orphaned vmware VM summary screen(Need to set Console type support is set to 'VNC')

https://bugzilla.redhat.com/show_bug.cgi?id=1472973
@h-kataria h-kataria force-pushed the fixed_visibility_code_for_vnc_console_button branch from daf5112 to 489b001 Compare July 21, 2017 17:22
@miq-bot
Copy link
Member

miq-bot commented Jul 21, 2017

Checked commit h-kataria@489b001 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. ⭐

@Loicavenel
Copy link

@h-kataria thanks

@h-kataria
Copy link
Contributor Author

@dclarizio please review

@dclarizio dclarizio merged commit d08a4c9 into ManageIQ:master Jul 24, 2017
@dclarizio dclarizio added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 24, 2017
simaishi pushed a commit that referenced this pull request Aug 9, 2017
…_console_button

Added a ems_id existence check around VM VNC console button visibility
(cherry picked from commit d08a4c9)

https://bugzilla.redhat.com/show_bug.cgi?id=1479929
@simaishi
Copy link
Contributor

simaishi commented Aug 9, 2017

Fine backport details:

$ git log -1
commit 887d712d1717d7aaed9176521261e10aa01b56e0
Author: Dan Clarizio <[email protected]>
Date:   Mon Jul 24 12:57:50 2017 -0700

    Merge pull request #1723 from h-kataria/fixed_visibility_code_for_vnc_console_button
    
    Added a ems_id existence check around VM VNC console button visibility
    (cherry picked from commit d08a4c9250db5370f3b75f8fef75601b0ee75589)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1479929

@h-kataria h-kataria deleted the fixed_visibility_code_for_vnc_console_button branch August 16, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants