-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a ems_id existence check around VM VNC console button visibility #1723
Added a ems_id existence check around VM VNC console button visibility #1723
Conversation
@Loicavenel seeing as both archived and orphaned VMs have no EMS and hence can't open a console, do you think we should totally hide this button or present it disabled with a tooltip saying consoles won't work against them? |
@dclarizio Question: For Orphan VMs, why EMS is required to open a console, IP is not enough? |
@Loicavenel we need to find out the api version of a connected EMS to figure out if that's a supported version, which in case does not exist. |
Discussed with @agrare and found out that it is not possible to open a VNC console for Archived or Orphaned VMs, so i am going to make changes to this PR to Hide the VNC Console button for such VMs. |
0c7796e
to
daf5112
Compare
calling 'api_version' for VM with ems_id as nil was throwing an error when accessing Archived/Orphaned vmware VM summary screen(Need to set Console type support is set to 'VNC') https://bugzilla.redhat.com/show_bug.cgi?id=1472973
daf5112
to
489b001
Compare
Checked commit h-kataria@489b001 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@h-kataria thanks |
@dclarizio please review |
…_console_button Added a ems_id existence check around VM VNC console button visibility (cherry picked from commit d08a4c9) https://bugzilla.redhat.com/show_bug.cgi?id=1479929
Fine backport details:
|
calling 'api_version' for VM with ems_id as nil was throwing an error when accessing Archived/Orphaned vmware VM summary screen(Need to set Console type support is set to 'VNC')
https://bugzilla.redhat.com/show_bug.cgi?id=1472973
@dclarizio please review/test
VMware VM with VNC console button
Orphaned VMware VM with no VNC console button