Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad use of constant in planning #2074

Merged

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Sep 1, 2017

TARGET_TYPE_CHOICES and WEEK_CHOICES are badly used.

Before;
screencapture-localhost-3000-planning-1504256118461

After:
Uploading screencapture-localhost-3000-planning-1504256646970.png…

@PanSpagetka PanSpagetka changed the title Fix TARGET_TYPE_CHOICES undefined Fix bad definition/use of constant in planning Sep 1, 2017
@PanSpagetka PanSpagetka force-pushed the target-type-choices-undefined branch from e2ffdc3 to 762799e Compare September 1, 2017 09:06
@PanSpagetka PanSpagetka changed the title Fix bad definition/use of constant in planning Fix bad use of constant in planning Sep 1, 2017
@miq-bot
Copy link
Member

miq-bot commented Sep 1, 2017

Checked commits PanSpagetka/manageiq-ui-classic@b4ca97d~...762799e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@dclarizio dclarizio added the bug label Sep 1, 2017
@dclarizio dclarizio requested review from skateman and removed request for skateman September 1, 2017 14:56
@h-kataria h-kataria added this to the Sprint 68 Ending Sep 4, 2017 milestone Sep 1, 2017
@h-kataria h-kataria merged commit a91e605 into ManageIQ:master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants