miq.notifications - update accordion sizing when opening/closing an accordion #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccordion opening/closing notifications triggers a resize which causes the styling to update correctly.. but expanding/closing a notification group does not do the same. Thus, the styling only fits until one expands an accordion. This makes notifications trigger a `resize` event every time a notification group is collapsed or expanded -> the scrollbar should always appear now https://bugzilla.redhat.com/show_bug.cgi?id=1445762
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/a75d94b502e694e23f40fe09f74b634b1aab0a58 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2017
miq.notifications - update accordion sizing when opening/closing an accordion (cherry picked from commit 1b72a2b) https://bugzilla.redhat.com/show_bug.cgi?id=1498525 https://bugzilla.redhat.com/show_bug.cgi?id=1498524
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening/closing notifications triggers a resize which causes the styling to update correctly..
but expanding/closing a notification group does not do the same.
Thus, the styling only fits until one expands an accordion.
This makes notifications trigger a
resizeevent every time a notification group is collapsed or expanded -> the scrollbar should always appear now.This pretty much fits what the current version in angular-patternfly does.
https://bugzilla.redhat.com/show_bug.cgi?id=1445762
https://bugzilla.redhat.com/show_bug.cgi?id=1445689