For Automate expression methods include ids #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits mkanoor/manageiq-ui-classic@51f2e5f~...03f1e67 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Expression Editor is used to build Advanced Search Filters and Automate Expression Methods.
When using it as an Automate Expression Method we need to compare object ids since custom dialogs for drop down items use ID to uniquely identify objects.
This PR passes in :include_id_columns => true into miq_adv_search_lists if we are using an expression method.
This PR depends on PR ManageIQ/manageiq#16242
The screen shot below shows the list of columns (fields) that a user can select when using the Regular Advanced Search
The screen shot below shows the list of columns (fields) that a user can select when using the Expression Method, you would see the ID column listed