Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quadicon on VM drift page #2792

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Fix quadicon on VM drift page #2792

merged 1 commit into from
Nov 22, 2017

Conversation

bmclaughlin
Copy link
Contributor

Before:
1502773-before

After:
1502773-after

@miq-bot add_labels bug, compute/infrastructure, gaprindashvili/yes

https://bugzilla.redhat.com/show_bug.cgi?id=1502773

@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2017

Checked commit bmclaughlin@9b86428 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

skateman
skateman approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@mzazrivec mzazrivec added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 22, 2017
@mzazrivec mzazrivec merged commit 7f5ab22 into ManageIQ:master Nov 22, 2017
@bmclaughlin bmclaughlin deleted the fix-vm-icon-on-drift branch November 22, 2017 12:22
simaishi pushed a commit that referenced this pull request Nov 27, 2017
@mzazrivec @simaishi
Merge pull request #2792 from bmclaughlin/fix-vm-icon-on-drift
9c4f8c3 
Fix quadicon on VM drift page
(cherry picked from commit 7f5ab22)

https://bugzilla.redhat.com/show_bug.cgi?id=1517905
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 9c4f8c33ab57c1555e2fcb2dc1b7aeb07a7de496
Author: Milan Zázrivec <[email protected]>
Date:   Wed Nov 22 10:22:01 2017 +0100

    Merge pull request #2792 from bmclaughlin/fix-vm-icon-on-drift
    
    Fix quadicon on VM drift page
    (cherry picked from commit 7f5ab22c5a0ccfa7a8bcb559ca0aaee88d303669)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees
No one assigned
Labels
bug compute/infrastructure gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bmclaughlin @miq-bot @simaishi @skateman @mzazrivec