Fire new event when toolbar click finish #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug,gaprindashvili/yes, gtls |
|
Toolbar issue from #3062 seems to be reintroduced with this PR. @karelhala : please, take a look. |
karelhala
force-pushed
the
toolbarClickFinish
branch
from
7298178 to
c1abd2c
Compare
|
@martinpovolny fixed. |
|
Restarted travis. |
…f GTL is present and click on toolbar finish Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530939
karelhala
force-pushed
the
toolbarClickFinish
branch
from
c1abd2c to
10754ad
Compare
|
Checked commit karelhala@10754ad with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good. Fixes the issue, does not reintroduce the toolbar issue. Waiting for Travis. |
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2018
Fire new event when toolbar click finish (cherry picked from commit db59822) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533234
|
Gaprindashvili backport details: |
AparnaKarve
added a commit
to AparnaKarve/manageiq-ui-classic
that referenced
this pull request
Jan 12, 2018
…3192 Fixes the multiselect dropdown linger issue https://bugzilla.redhat.com/show_bug.cgi?id=1533808
AparnaKarve
added a commit
to AparnaKarve/manageiq-ui-classic
that referenced
this pull request
Jan 12, 2018
…3192 Fixes the multiselect dropdown linger issue https://bugzilla.redhat.com/show_bug.cgi?id=1533808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes present class on main div when clicked on GTL item
Class which was still present was
miq-sand-paperwhich caused greyed content background. This PR fires new event when click on toolbar is finished and if such event is cought by report data it will check if any grid is present and if so, it will setmiq-sand-paperback.Related issues/PRs
#3062
BZ
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530939