Check role features in report data request #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
role feature has been inherited from controller and action name and it leads to check role for example ems_block_storage_report_data and it should be ems_block_storage_show_list.
|
Checked commit lpichler@9890ab0 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lpichler is this gaprindashvili/yes ? |
|
@mzazrivec it can be, thanks for merging :) @miq-bot gaprindashvili/yes |
|
@lpichler unrecognized command 'gaprindashvili', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
I am not sure about the nested list case here where a controller for entity A displays a list of entities of type B. In that case we are executing a test for A if I read the code correct. Ping @lpichler |
|
@lpichler Please add BZ link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that on report data request the check on role feauture was skipped
role feature has been inherited from controller and action name and
it leads to check role
for example ems_block_storage_report_data and it should be
ems_block_storage_show_list.
@miq-bot assign @martinpovolny
cc @karelhala
@miq-bot add_label bug