Support for hidden columns in reports and views #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtanzillo Cannot apply the following label because they are not recognized: reporting enhancement reporting wip |
gtanzillo
force-pushed
the
report-hidden-cols-ui
branch
from
4aa1169 to
f6ad48b
Compare
|
@miq-bot add_label transformation |
|
@gtanzillo Cannot apply the following label because they are not recognized: reporting |
Columns, including headers with MiqReport#col_options[<column_name>][:hidden] = true should not are included in html, pdf, text output formats and only be included in csv
gtanzillo
force-pushed
the
report-hidden-cols-ui
branch
from
f6ad48b to
42e74d9
Compare
|
@dclarizio @h-kataria Backend PR has been merged. |
|
@gmcculloug @gtanzillo i am working on a spec test to verify these changes, once i have that, i will make a commit against this PR. |
h-kataria
force-pushed
the
report-hidden-cols-ui
branch
from
815162f to
bbda297
Compare
|
Checked commits gtanzillo/manageiq-ui-classic@42e74d9~...bbda297 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@dclarizio verified changes in UI, looks good |
dclarizio
changed the title
simaishi
pushed a commit
that referenced
this pull request
Jun 1, 2018
Support for hidden columns in reports and views (cherry picked from commit adb24a0)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Columns, including headers with MiqReport#col_options[<column_name>][:hidden] = true should not
are included in html, pdf, text output formats and only be included in csv
Depends on ManageIQ/manageiq#17133
/cc @dclarizio