Display Cloud Tenants relation at Network Manager #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we display relation (with object count) at Network Manager details page. Clicking on relation redirects user to a `display=cloud_tenants` page. RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574903 Signed-off-by: Miha Pleško <[email protected]>
|
@himdel some network providers (Nuage) inventory Cloud Tenants. Until now relation to Cloud Tenants was not displayed on Network Manager's details page, hence this PR. |
|
Checked commit miha-plesko@ae795a5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, works for openstack, does not break for any other provider type (shows 0) 👍 |
|
@terezanovotna I'm just testing tagging and adding labels. |
|
@terezanovotna add-label ux/review |
|
@AnjaV Pretty sure the bot is called @miq-bot , not @terezanovotna ;) Also, Hope it helps :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we display relation (with object count) at Network Manager details page. Clicking on relation redirects user to a
display=cloud_tenantspage. Find screenshots below.Screenshot of Network Manager details page:
Screenshot of a page that renders when user clicks on "Cloud Tenants" relation:
Video: http://x.k00.fr/cloudtenants
Related PR (but not blocking): ManageIQ/manageiq-providers-nuage#92
RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574903
@miq-bot assign @himdel
@miq-bot add_label enhancement