Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the Status of some topology nodes #4347

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Set the Status of some topology nodes #4347

merged 1 commit into from
Jul 25, 2018

Conversation

caiocmpaes
Copy link
Contributor

@caiocmpaes caiocmpaes commented Jul 24, 2018

What this PR does:

  • Set the status of the PhysicalChassis and PhysicalStorage nodes in the topology view to be relative to the entity's health_state;
  • Set the status of the Hosts nodes in the topology view to be relative to the entity's state;
  • Set the status of the Vms nodes in the topology view to be relative to the entity's power_state.

Note: Physical Chassis and Physical Storage were added because as soon as they are added to the topology, the status border will work for them.

topology

As the picture shows, the nodes get borders in one of this colors:

  • Gray => Unknown Health State status (Chassis/Storage) or Power State status (Host/VM);
  • Green => Valid or On;
  • Yellow => Warning;
  • Red => Critical;

@caiocmpaes
Copy link
Contributor Author

@skateman this pull request adds status in nodes to the physical infra topology view.

With this new four nodes, the topology will be completed. This is a continuation of #4288

when ManageIQ::Providers::Redhat::InfraManager::Host
entity.state ? entity.state.downcase.capitalize : _('Unknown')
when ManageIQ::Providers::Redhat::InfraManager::Vm
entity.power_state ? entity.power_state.downcase.capitalize : _('Unknown')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why just Redhat::InfraManager, what about all the others? Shouldn't be these simply just Host and Vm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I fixed these unnecessary namespaces use. 😄

@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commit https://github.com/caiocmpaes/manageiq-ui-classic/commit/5026aba4d07689e263d93d4899365379d3a0a5e3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@mzazrivec mzazrivec added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 25, 2018
@mzazrivec mzazrivec merged commit 4ccb39c into ManageIQ:master Jul 25, 2018
@caiocmpaes caiocmpaes deleted the add_status_of_some_topology_nodes branch July 25, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants